Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing minor syntax in DataView example code #62560

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fixing minor syntax in DataView example code #62560

merged 1 commit into from
Jun 14, 2024

Conversation

aaronware
Copy link
Contributor

What?

Fixing a syntax error

Why?

Helping users copy/paste code examples

How?

Adding a comma to an array of objects

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronware <aware@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 13, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @aaronware! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

t-hamano
t-hamano approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers props-bot Adding this label triggers the Props Bot workflow for a PR. labels Jun 14, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jun 14, 2024
@t-hamano t-hamano merged commit 91472e5 into WordPress:trunk Jun 14, 2024
65 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 14, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@aaronware @t-hamano @patil-vipul
Fixing minor syntax in dataview example code (WordPress#62560)
fc53146 
Co-authored-by: aaronware <aware@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 18.6
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronware @t-hamano